Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic support for mathematica #2921

Merged
merged 16 commits into from Jun 2, 2021
Merged

Conversation

@msollami
Copy link
Contributor

@msollami msollami commented May 28, 2021

Support for the wolfram language:

  • Followed "new language" tutorial
  • Added html examples and test files
  • Initial work highlights basic common expressions including numbers, system-level symbols, comments, operators, and strings
Support for the wolfram language:
- Followed "new language"  tutorial
- Added html examples and test files
- Initial work highlights basic common expressions including numbers, system-level symbols, comments, operators, and strings
@github-actions
Copy link

@github-actions github-actions bot commented May 28, 2021

JS File Size Changes (gzipped)

A total of 3 files have changed, with a combined diff of +585 B (+12.9%).

file master pull size diff % diff
components/prism-wolfram.min.js 0 Bytes 537 B +537 B +100.0%
plugins/autoloader/prism-autoloader.min.js 2.21 KB 2.23 KB +19 B +0.9%
plugins/show-language/prism-show-language.min.js 2.33 KB 2.36 KB +29 B +1.2%

Generated by 🚫 dangerJS against 50a8722

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Thank you for making this language definition @msollami!

I left you a few comments with things to improve.

Also, I have a question about class-name and regex: Are these really class names/regexes? I don't know Mathematica but the patterns don't look like that to me.

components/prism-wolfram.js Outdated Show resolved Hide resolved
components/prism-wolfram.js Outdated Show resolved Hide resolved
components/prism-wolfram.js Show resolved Hide resolved
components/prism-wolfram.js Outdated Show resolved Hide resolved
components/prism-wolfram.js Outdated Show resolved Hide resolved
components.json Outdated Show resolved Hide resolved
components/prism-wolfram.js Outdated Show resolved Hide resolved
msollami and others added 8 commits Jun 1, 2021
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Moved string rule after comment to make highlighting faster.
Added the alias 'mathematica'
components.json Outdated Show resolved Hide resolved
components/prism-wolfram.js Outdated Show resolved Hide resolved
@msollami
Copy link
Contributor Author

@msollami msollami commented Jun 1, 2021

@RunDevelopment Thanks for your review & help, this looks good to me now.

components/prism-wolfram.js Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jun 2, 2021

Sorry, it was quite late for me yesterday.

I agree that it's pretty much gtg now. We can merge this after the lining errors and my last comment have been addressed.

msollami and others added 2 commits Jun 2, 2021
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Fixing linter errors
@msollami
Copy link
Contributor Author

@msollami msollami commented Jun 2, 2021

I agree that it's pretty much gtg now. We can merge this after the lining errors and my last comment have been addressed.

@RunDevelopment Ok, I added a new line at the end of file; changed tabs to spaces; and removed trailing whitespace, so the linter should be happy now. Is there a way I can trigger the action to run the linter?

@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jun 2, 2021

Is there a way I can trigger the action to run the linter?

No, I have to trigger this manually every time. But all the CI does is run npm run lint, so you can do this locally. In many cases, npm run lint:fix will the erros.

components.json Outdated Show resolved Hide resolved
@msollami
Copy link
Contributor Author

@msollami msollami commented Jun 2, 2021

npm run lint

Good to know! Ok, it now passes the linter checks locally.

@RunDevelopment RunDevelopment merged commit c4f6b2c into PrismJS:master Jun 2, 2021
11 checks passed
@RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Jun 2, 2021

Thank you for contributing @msollami!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants