Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell-session: Fixed command false positives #3048

merged 2 commits into from Sep 6, 2021


Copy link

This fixes #3047.


  • A space is now required after the shell symbol.
  • Path-only user infos have to start with a special character to more precisely identify paths. (I split up the regex, so I could comment on the change.)

Copy link

github-actions bot commented Aug 24, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +31 B (+6.3%).

file master pull size diff % diff
components/prism-shell-session.min.js 495 B 526 B +31 B +6.3%

Generated by 🚫 dangerJS against 5715400

Copy link

@RunDevelopment Mind blown by how fast you handle issue. Thanks!

Copy link

Hey @RunDevelopment, just stumbled upon another edge case.

Not sure why < /dev/random | head -c 8 is not part of command.

Copy link
Member Author

Thanks for reporting @sunknudsen!

Copy link

Thanks so much for improving shell session support… very useful when writing guides. 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Lines falsely identified as commands in shell session
2 participants