Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docker and podman commands to Bash language #3237

Merged
merged 2 commits into from Nov 29, 2021

Conversation

AmebaBrain
Copy link
Contributor

@AmebaBrain AmebaBrain commented Nov 28, 2021

Added following commands to the bash language

  • docker
  • docker-compose
  • podman
  • podman-compose

According to guidelines minified file is not touched.

@github-actions
Copy link

github-actions bot commented Nov 28, 2021

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +19 B (+0.7%).

file master pull size diff % diff
components/prism-bash.min.js 2.87 KB 2.89 KB +19 B +0.7%

Generated by 🚫 dangerJS against 57adfc3

@RunDevelopment
Copy link
Member

RunDevelopment commented Nov 28, 2021

Thank you for the PR @AmebaBrain!

According to guidelines minified file is not touched.

When changing a language, the minified files are supposed to be updated. Seems like our docs need some clarification. Where did you read this?

@AmebaBrain
Copy link
Contributor Author

AmebaBrain commented Nov 28, 2021

@RunDevelopment

2nd point in Contribute to Prism! section of readme says

Limit your changes to the unminified files in the components/ folder. prism.js and all minified files are also generated automatically by our build system.

Anyway, I've pushed the changes to the minified file as well. Because I did this from a new Windows based laptop please check whether line ending in a minified file is ok. If not, I will re-execute npm run build from Linux based machine day after tommorow.

@RunDevelopment
Copy link
Member

RunDevelopment commented Nov 29, 2021

2nd point in Contribute to Prism! section of readme says

Good point. I'll clarify this tomorrow.

@RunDevelopment RunDevelopment merged commit 8c5ed25 into PrismJS:master Nov 29, 2021
12 checks passed
@RunDevelopment
Copy link
Member

RunDevelopment commented Nov 29, 2021

Thank you for contributing @AmebaBrain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants