Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the chinese readme translation #750

Closed
wants to merge 1 commit into from
Closed

Add the chinese readme translation #750

wants to merge 1 commit into from

Conversation

bimohxh
Copy link

@bimohxh bimohxh commented Sep 1, 2015

awesomes.cn is an open source for github web repos, we offer translation for repo's readme and improve this to let our chinese users use the repo easily.In addition, we want more more developer join us to enrich the chinese readmes.

awesomes.cn is an open source for github web repos, we offer translation for repo's readme and improve this to let our chinese users use the repo easily.In addition, we want more more developer join us to enrich the chinese readmes.
@LeaVerou
Copy link
Member

Hey, thanks for your work!
I might be missing something, but the website you linked to just has the same info as the readme here, in English (not Chinese). What am I missing?

@bimohxh
Copy link
Author

bimohxh commented Nov 25, 2015

Just visit http://www.awesomes.cn/repo/PrismJS/prism you see the same info as the readme here,because your browser language is English.Our website support both Chinese and English language,so we will detect the browser language ,if it is Chinese we will default show Chinese translation,otherwise show the English readme.And we offer a language switch on the top right as EN / 中,you can click to read Chinese version.

@sukrosono
Copy link

ping to update

@LeaVerou
Copy link
Member

Hi there @awesomes-cn, even when I select Chinese, there is a large blob of untranslated text and it's only very short bits of text that have been translated. Am I missing something?

@LeaVerou
Copy link
Member

LeaVerou commented Jun 4, 2018

Hi there,

Sorry for the delay.
I would be inclined to merge this, but not as the first thing immediately after the heading. How about a "Translations" section at the end of the readme, with a list that has this as the only item?

@mAAdhaTTah
Copy link
Member

@LeaVerou If we moved it to a list, should we keep the badge?

@LeaVerou
Copy link
Member

LeaVerou commented Jun 5, 2018

Sure, why not.

@mAAdhaTTah mAAdhaTTah changed the base branch from gh-pages to master June 5, 2018 20:17
@mAAdhaTTah
Copy link
Member

@bimohxh Landed in f2b1964 – thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants