Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when deselecting mods after searching for another mod #1212

Closed
1 task done
DarkIceXD opened this issue Jun 16, 2023 · 2 comments · Fixed by #1228
Closed
1 task done

Crash when deselecting mods after searching for another mod #1212

DarkIceXD opened this issue Jun 16, 2023 · 2 comments · Fixed by #1228
Labels
bug Something isn't working
Milestone

Comments

@DarkIceXD
Copy link

DarkIceXD commented Jun 16, 2023

Operating System

tested on Linux and Windows

Version of Prism Launcher

Prism Launcher 7.1

Version of Qt

Qt 5.15.9

Description of bug

When deselecting mods, after a search, in the "Download mods" menu, the launcher crashes completely.

Steps to reproduce

  • create a new instance with Fabric or Forge, etc.
  • edit the instance
  • go to "Mods"
  • press "Download mods"
  • select any mod
  • press "Select mod for download"
  • enter anything into the search field so that the mod disappears
  • press "Deselect mod for download"
  • crash

Suspected cause

Very likely using a reference to the mod entry inside the GUI that got removed after searching. (use-after-free)

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@DarkIceXD DarkIceXD added the bug Something isn't working label Jun 16, 2023
@LackingCats
Copy link

I have the same issue, Flatpak PrismLauncher 7.1
It was very annoying ._.

@DarkIceXD
Copy link
Author

DarkIceXD commented Jun 17, 2023

This isn't a new bug either. It was present in earlier versions too. I also forgot to add that the same thing happens when selecting mods so:

  • create a new instance with Fabric or Forge, etc.
  • edit the instance
  • go to "Mods"
  • press "Download mods"
  • select any mod but don't press the "Select mod for download" button
  • enter anything into the search field so that the mod disappears
  • press "Select mod for download"
  • crash

Trial97 added a commit to Trial97/PrismLauncher that referenced this issue Jun 19, 2023
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 mentioned this issue Jun 19, 2023
@Scrumplex Scrumplex added this to the 7.2 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants