Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1212 #1228

Merged
merged 1 commit into from Jun 21, 2023
Merged

Fixes #1212 #1228

merged 1 commit into from Jun 21, 2023

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Jun 19, 2023

Fixes #1212

If you start to search just clear packDescription(it's now similar to other resources)

@Trial97
Fixes PrismLauncher#1212
d028580 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
TheKodeToad
TheKodeToad approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@TheKodeToad TheKodeToad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! But I'm curious why changes would need to be made to the generic resource page

@Trial97
Copy link
Member Author

Trial97 commented Jun 19, 2023

Initially, I thought that the issue was with the fact that we access the current_pack without checking if it really exists.
After I made that change I saw that the issue lies with the fact that when you search the packDescription doesn't clear( keeping an invalid state present).
So after fixing the real cause I just kept the change in the generic resource page as a safety measure against crashes.

@TheKodeToad TheKodeToad added this to the 7.2 milestone Jun 19, 2023
@TayouVR TayouVR added the bug Something isn't working label Jun 21, 2023
TayouVR
TayouVR approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@TayouVR TayouVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheKodeToad TheKodeToad merged commit 0975dbc into PrismLauncher:develop Jun 21, 2023
14 checks passed
@Trial97 Trial97 deleted the curent_pack_crash branch June 24, 2023 06:35
Scrumplex pushed a commit that referenced this pull request Jul 16, 2023
@TheKodeToad @Scrumplex
Merge pull request #1228 from Trial97/curent_pack_crash
b1fe4d1 
Fixes #1212
@Scrumplex Scrumplex added the manual backport PRs that have been backported manually label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TayouVR TayouVR TayouVR approved these changes

@TheKodeToad TheKodeToad TheKodeToad approved these changes

Assignees
No one assigned
Labels
bug Something isn't working manual backport PRs that have been backported manually
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

Crash when deselecting mods after searching for another mod
4 participants
@Trial97 @TayouVR @TheKodeToad @Scrumplex