Fix: signal/slot macro -> func pointer & network fixes #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryex
force-pushed
the
fix/network_and_signals
branch
3 times, most recently
from
6e97885
to
980362a
Compare
- convert qt connect calls to use function pointers instead of the signal/slot macros wherever practical (UI classes were mostly left alone, target was tasks and processes) - give signals an explicit receivers to use the static method over the instance method wherever practical - ensure networks tasks are using the `errorOccured` signal added in Qt5.15 over the deprecated `error` signal - ensure all networks tasks have an sslErrors signal connected - add seemingly missing `MinecraftAccount::authSucceeded` connection for `MSAInteractive` login flow Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Ryex
force-pushed
the
fix/network_and_signals
branch
from
980362a
to
12f0d51
Compare
|
This appears to fix a crash in #904. |
Refrencing GDlauncher and ATLauncher code for auth as well as https://learn.microsoft.com/en-us/gaming/gdk/_content/gc/reference/live/rest/additional/httpstandardheaders it is possible some of microsoft's server's are rejecting our request because of this missing header? Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Ryex
force-pushed
the
fix/network_and_signals
branch
from
1588399
to
495103f
Compare
1 task
flowln
approved these changes
May 11, 2023
There was a problem hiding this comment.
Noteworth: The fix in #904 is mostly due to adding the QNetworkReply::errorOccurred to Upload, which is necessary for task abortion to work correctly.
damn there's a lot of code that should probably use our net/ stuff but doesn't xd
great work here tho! :D
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
Conflicting with develop |
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
|
fixed |
DioEgizio
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errorOccuredsignal added in Qt5.15 over the deprecatederrorsignalMinecraftAccount::authSucceededconnection forMSAInteractivelogin flowx-xbl-contract-versionheader during xbox auth step (GDLauncher and ATLauncher set this)