mrpack export

[TheKodeToad]

Preview

Stuff

kind of inspired by MultiMC/Launcher#5052, but i didn't take any code i promise

Partially fixes (pls don't close issue github) #269.

TODO:

• Reuse information from the index (we can't use CurseForge urls though as they are not whitelisted).
• Abort task!
• Make it not crash.
• Make the code good.
• Use threads properly! (kind of done?)

Fairly important but not critical (probably won't do in this PR):

• Maybe some persistence in what the user selected. (support the packwiz pack.toml file? or maybe just add a version and summary field to the onesix format.)
• Side specific files.
• Optional files. We only know if this is available once the URLs are too.

Future:

• Uploading to the site automatically.
• CurseForge export.

I didn't keep my promise :(.

[Ryex]

Nothing is immediately jumping out as causing the crash. I can't exactly test it myself atm but cleaning up the code should help narrow down the problem. and you may stop logic errors when you do.

[TheKodeToad]

The lambda stuff was only intended to be temporary, but thanks for the suggestions!

[RaptaG]

I want to hug you rn toad

[RaptaG]

(One of the) Best PR(s) in Prism

[TheKodeToad]

The code is bad, and it crashes! How can you say this?
Well, it does work but you have to open it up again.

[RaptaG]

It's the idea, the PR itself. It will be complete one day.

[TheKodeToad]

🤞

[kosma]

I gave this branch a spin, and it seems to export all my mods as overrides, instead of nicely linking to Modrinth downloads in the medatada. Is something broken?

[TheKodeToad]

Are the mods unmodified, in the "mods" folder, and do they end with ".jar" or ".jar.disabled"?
(it seems to work for me)

[kosma]

MultiMC exports the same pack from the same folder correctly. Using a build from this branch, the entire JSON is just:

{"dependencies":{"fabric-loader":"0.14.19","minecraft":"1.19.4"},"files":[],"formatVersion":1,"game":"minecraft","name":"Kosmopack Prism Export Test","summary":"Possums","versionId":"1.0"}

And all the mod files (*.jar and *.jar.disabled) land in overrides.

The build I'm using is PrismLauncher-Windows-MSVC-Portable-f93bad5-Debug from here: https://github.com/PrismLauncher/PrismLauncher/actions/runs/4861729182

[TheKodeToad]

Could you send an instance zip to reproduce (with nothing personal such as logs of course)?

[kosma]

Here's the instance: https://github.com/kosma/kosmopack

[TheKodeToad]

It exports fine for me... weird

[TheKodeToad]

[almost] Everything should be fixed! tysm for the help

it's a bit tall now since #961

[flowln]

it's a bit tall now since #961

changing both the height and the minimum height of ProgressDialog to 100 seems to fix this.

Those are my last remarks. You did a good job! Thanks for working on this 🙂

[TheKodeToad]

You're welcome! I don't think I should change the progress dialog.

[TheKodeToad]

@kosma Mentioning you because you've hopefully unsubscribed from this pr :P

Could you send launcher logs (making sure to remove anything personal such as accent tokens)?

[Ryex]

Do the latest changes Kode has made solve the speed issue for you @flowln ?
everything is looking good from where I'm standing.

[flowln]

Do the latest changes Kode has made solve the speed issue for you @flowln ?
everything is looking good from where I'm standing.

Yup, looking nice. Thanks @Ryex and @TheKodeToad, great work! :)

[Ryex]

... @flowln Can I... make this my first merge?

[flowln]

... @flowln Can I... make this my first merge?

Yes! 🙂