Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mod count to mods page #1119

Merged
merged 6 commits into from Jun 20, 2023
Merged

Add mod count to mods page #1119

merged 6 commits into from Jun 20, 2023

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Jun 6, 2023

Fixes #451

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@getchoo getchoo added enhancement New feature or request simple change needs-testing PRs that should be tested a bit more before being merged labels Jun 12, 2023
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not exactly sure what's going on here: in my testing the mods page (and only the mods page) will have the install/select count appear when you first view it, but if you switch to a different tab like resource packs and go back, it won't appear at all until you have selected a mod.

launcher/ui/pages/instance/ExternalResourcesPage.cpp Outdated Show resolved Hide resolved
@Trial97
Copy link
Member Author

Trial97 commented Jun 15, 2023

I fixed the mentioned comment but in order to fix all of them I removed a line that was prefixed by the following comment:

// Prevent a weird crash when trying to open the mods page twice in a session o.O
disconnect(mods.get(), &ModFolderModel::updateFinished, this, 0);

I could not get it to crash as the description is vague. But if somebody knows why that line was added let me know.

@getchoo
Copy link
Member

getchoo commented Jun 18, 2023

it seems @flowln was the one who left this (sorry for the ping, not sure who else to ask :p). could you shed some light on this so we can see if it's still needed?

@flowln
Copy link
Contributor

flowln commented Jun 18, 2023

The description isn't vague, it is just as simple as it sounds: Without that line, it used to be the case that the application would crash if you opened the mods page, switched pages, and returned back to the mods page. I suppose the underlying cause of the crash got fixed at some point, so the line doesn't do much now. Nice!

Also, you can probably remove mods from the lambda now.

@getchoo
Copy link
Member

getchoo commented Jun 19, 2023

thank you so much! just wanted to make sure :)

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just tested this again as well and it seems to good to go! the only other thing i would recommend is following flow's suggestion

@getchoo getchoo removed the needs-testing PRs that should be tested a bit more before being merged label Jun 19, 2023
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@DioEgizio DioEgizio added this to the 8.0 milestone Jun 20, 2023
Copy link
Member

@DioEgizio DioEgizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work as expected

@getchoo
Copy link
Member

getchoo commented Jun 20, 2023

thanks!

@getchoo getchoo merged commit ca65913 into PrismLauncher:develop Jun 20, 2023
14 checks passed
@Scrumplex Scrumplex changed the title Added dynamic page extra info Add mod count to mods page Jul 29, 2023
@Scrumplex Scrumplex added the changelog:added A PR that appears under "Added" in the changelog label Jul 29, 2023
@Trial97 Trial97 deleted the mods_txt branch September 29, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added A PR that appears under "Added" in the changelog enhancement New feature or request simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show mod count in mods tab
6 participants