New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mod count to mods page #1119
Conversation
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not exactly sure what's going on here: in my testing the mods page (and only the mods page) will have the install/select count appear when you first view it, but if you switch to a different tab like resource packs and go back, it won't appear at all until you have selected a mod.
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
I fixed the mentioned comment but in order to fix all of them I removed a line that was prefixed by the following comment:
I could not get it to crash as the description is vague. But if somebody knows why that line was added let me know. |
it seems @flowln was the one who left this (sorry for the ping, not sure who else to ask :p). could you shed some light on this so we can see if it's still needed? |
The description isn't vague, it is just as simple as it sounds: Without that line, it used to be the case that the application would crash if you opened the mods page, switched pages, and returned back to the mods page. I suppose the underlying cause of the crash got fixed at some point, so the line doesn't do much now. Nice! Also, you can probably remove |
thank you so much! just wanted to make sure :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just tested this again as well and it seems to good to go! the only other thing i would recommend is following flow's suggestion
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to work as expected
thanks! |
Fixes #451