Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Page container extra info set on logs page #1272

Merged
merged 1 commit into from Jun 25, 2023
Merged

fix: Page container extra info set on logs page #1272

merged 1 commit into from Jun 25, 2023

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Jun 25, 2023 •
edited by Scrumplex

@Trial97
fix: Page container extra info set on logs page
6d0e255 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@getchoo getchoo added the bug Something isn't working label Jun 25, 2023
TheKodeToad
TheKodeToad approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@TheKodeToad TheKodeToad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the method's behaviour isn't that clear 😭

oh well

this looks like it works! :P

@getchoo getchoo added this to the 8.0 milestone Jun 25, 2023
@getchoo getchoo merged commit 903fae9 into PrismLauncher:develop Jun 25, 2023
14 checks passed
@Ryex Ryex modified the milestones: 8.0, 7.2 Jul 9, 2023
@TheKodeToad TheKodeToad modified the milestones: 7.2, 8.0 Jul 14, 2023
@TheKodeToad
Copy link
Member

Regardless whether we are releasing 7.2 or not, 8.0 is the correct milestone.

@Scrumplex Scrumplex added the changelog:merged A PR that will be merged into a parent PR in the changelog label Jul 29, 2023
@Trial97 Trial97 deleted the fix_selected branch September 29, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryex Ryex Ryex approved these changes

@getchoo getchoo getchoo approved these changes

@TheKodeToad TheKodeToad TheKodeToad approved these changes

Assignees
No one assigned
Labels
bug Something isn't working changelog:merged A PR that will be merged into a parent PR in the changelog
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Trial97 @TheKodeToad @Ryex @getchoo @Scrumplex