Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Exclude .git directory from the source code tarball #1140

Merged
merged 1 commit into from Jun 13, 2023
Merged

CI: Exclude .git directory from the source code tarball #1140

merged 1 commit into from Jun 13, 2023

Conversation

guihkx
Copy link
Contributor

@guihkx guihkx commented Jun 9, 2023 •
edited

Reduces its final size from 17.1 MiB to 7.9 MiB.

@guihkx
ci: exclude .git directory from the source code tarball
93436b0 
Reduces the its final size from 17.1 MiB down to 7.9 MiB.

Signed-off-by: guihkx <626206+guihkx@users.noreply.github.com>
@guihkx guihkx force-pushed the ci-exclude-git-folder-from-sources-tarball branch from 8468d84 to 93436b0 Compare June 9, 2023 03:56
@Scrumplex Scrumplex added this to the 7.1 milestone Jun 9, 2023
@getchoo getchoo added enhancement New feature or request actions Issues and PRs related to GH actions and other CIs we might have packaging Issues and PRs related to packaging (CI builds or package managers) labels Jun 12, 2023
getchoo
getchoo approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a packager i like this a lot. the only worry i had was for our buildconfig stuff, but since this is exclusive to releases and builds without git (the cli or directory) are already assumed to be stable, this lgtm :)

@getchoo getchoo merged commit 703f769 into PrismLauncher:develop Jun 13, 2023
14 checks passed
@guihkx guihkx deleted the ci-exclude-git-folder-from-sources-tarball branch June 13, 2023 16:53
@flowln flowln mentioned this pull request Jun 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@txtsd txtsd txtsd approved these changes

@getchoo getchoo getchoo approved these changes

@DioEgizio DioEgizio DioEgizio approved these changes

Assignees
No one assigned
Labels
actions Issues and PRs related to GH actions and other CIs we might have enhancement New feature or request packaging Issues and PRs related to packaging (CI builds or package managers)
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@guihkx @txtsd @getchoo @DioEgizio @Scrumplex