Hide the Git commit entry on the About dialog when the build doesn't have git stuff support #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the Git commit string being "GITDIR-NOTFOUND" on the About page when building a package from the bundled source archive. Signed-off-by: flow <flowlnlnln@gmail.com>
TheKodeToad
approved these changes
Jun 17, 2023
We might be able to "pre-bake" it with a small text file that gets read by our CMake configuration |
Scrumplex
approved these changes
Jun 17, 2023
|
I think this is among other prs which would make sense in a 7.2 release 🤷♀️ |
|
i agree. if #1140 was merged in a minor release, i don't see why a fix for it would be relegated to a major release |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides the Git commit string
GITDIR-NOTFOUNDon the About page when building a package from the bundled source archive. This was introduced by #1140 for packages that use the bundled tar.gz source file 🙂