Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't instantiate nixpkgs in Flake #1574

Merged
merged 4 commits into from Sep 4, 2023
Merged

Don't instantiate nixpkgs in Flake #1574

merged 4 commits into from Sep 4, 2023

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex added this to the 8.0 milestone Aug 28, 2023
@Scrumplex Scrumplex added packaging Issues and PRs related to packaging (CI builds or package managers) Linux Issues and PRs related to Linux specifically labels Aug 28, 2023
@Scrumplex Scrumplex requested a review from getchoo August 28, 2023 08:28
@Scrumplex Scrumplex added the changelog:changed A PR that appears under "Changed" in the changelog label Aug 28, 2023
getchoo
getchoo requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the good read :)

i like this, just one little note

nix/distribution.nix Outdated Show resolved Hide resolved
@Scrumplex Scrumplex requested a review from getchoo August 28, 2023 13:18
getchoo
getchoo requested changes Aug 28, 2023
View reviewed changes
nix/distribution.nix Show resolved Hide resolved
nix/pkg/wrapper.nix Outdated Show resolved Hide resolved
nix/distribution.nix Outdated Show resolved Hide resolved
@Scrumplex
fix(nix): include udev dependency
707da5a 
See NixOS/nixpkgs#252425

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
Scrumplex commented Sep 3, 2023
View reviewed changes
nix/distribution.nix Outdated Show resolved Hide resolved
@getchoo
refactor(nix): use fixed points over rec
bbf4e3b 
Signed-off-by: seth <getchoo@tuta.io>
@Scrumplex
refactor(nix): use pre-commit flake module
2918d61 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex merged commit e9ecdd0 into PrismLauncher:develop Sep 4, 2023
32 checks passed
@Scrumplex Scrumplex deleted the refactor-flake branch September 4, 2023 15:02
evan-goode added a commit to unmojang/PollyMC that referenced this pull request Sep 5, 2023
@evan-goode
Port over recent Nix packaging changes from Prism Launcher
e47186e 
Resolves fn2006#85

Prism Launcher has refactored a lot of their Nix recently. This includes
the changes from
PrismLauncher/PrismLauncher#1574, but I'm not
100% sure that's what fixed the issue here, it could have been some
other change along the way.

Signed-off-by: Evan Goode <mail@evangoo.de>
@evan-goode evan-goode mentioned this pull request Sep 5, 2023
Merged
@getchoo getchoo mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

@Trial97 Trial97 Trial97 approved these changes

Assignees
No one assigned
Labels
changelog:changed A PR that appears under "Changed" in the changelog Linux Issues and PRs related to Linux specifically packaging Issues and PRs related to packaging (CI builds or package managers)
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Scrumplex @Trial97 @getchoo