enabled GenericManagedPackPage for all non managed packs

[Trial97]

Parrent PR: #1405
should fix: #1394 (comment)
From that comment looks like I did not fix the original issue just extended the functionality of the managed packs(downloaded through prism from modrinth/curseforge)
This PR aims to have a generic managed pack page for all non-managed packs, allowing the user to update them using files.
How to test:

• download a modrinth pack( an older version)
• install it using the mrpack file
• download a newer version of the pack(outside of prism)
• click edit instance on the created instance
• you should have a new tab named Pack Manager(I'm bad at names; feel free to suggest one)
• entering that page you will be greeted with:
  • the pack name(the name of the instance)
  • a big button with upload from file
  • a changelog that reflects the notes content
• click on the upload from the file
• select the new version
• profit

Also fixes #1731

[TheKodeToad]

Maybe have the tab be called Update, Updates, Updater, Update Manager (any of those) across mod platforms - perhaps just the icon could change
and the default icon could just be the updater icon

[TheKodeToad]

It would nice to be able to bind and unbind from a provider too...

[Trial97]

It would nice to be able to bind and unbind from a provider too...

Nice but let's keep this PR for just this(open an issue regarding this)

I updated the icon( now it should use the updater icon), and decided on "Pack Manager" for the page name, and that only if it is not curse or modrinth

[TheKodeToad]

Maybe have the tab be called Update, Updates, Updater, Update Manager (any of those) across mod platforms - perhaps just the icon could change and the default icon could just be the updater icon

I think this is better tbh and i don't want to open another pr before 8.0

[Trial97]

are you having an issue with the new page name(Pack Manager) or the fact that is not the same name across providers?

[TheKodeToad]

I can try implementing it myself...

[DioEgizio]

Maybe have the tab be called Update, Updates, Updater, Update Manager (any of those) across mod platforms - perhaps just the icon could change and the default icon could just be the updater icon

What about just calling it "Modpack"?

[TheKodeToad]

Yeah... I realised those look a bit weird

[TheKodeToad]

That will break the Website: link + you need to translate

[Trial97]

@TheKodeToad you either tell me exactly the lines or describe better. As I really do not understand what you want from me?
What will break the Website? what link?
The translation stuff is related to the return from here: https://github.com/PrismLauncher/PrismLauncher/pull/1727/files#diff-98ffe9e93f22873408db9da76d7f772d0cd74d88abe5106a26340f62ac4fb60dR145?

[TheKodeToad]

• tr("Modpack")

• PrismLauncher/launcher/ui/pages/instance/ManagedPackPage.cpp

  Line 136 in c638a63

  ui->packOrigin->setText(tr("Website: <a href=%1>%2</a> | Pack ID: %3 | Version ID: %4")

[Trial97]

Thanks that helps a lot.

[DioEgizio]

it's adding the tab even on manual instances, but you can't update from onesix zips so this probably is a problem

[TheKodeToad]

it's a bit weird

[Trial97]

Yeah, there is no way right now to update from onsix zip. And is not so simple to add it right now(it needs a bit of a rewrite on how onsix instance is created.

Should I remove both the PR and the issue from the milestone?
Maybe we can just add a warning, regarding this, and have it implemented in a following release?

[TheKodeToad]

actually it should be fine as-is

[DioEgizio]

I actually think this is a really big UX problem so unless we can exclude onesix now imo we should move this out of the milestone

[TheKodeToad]

The point is to include OneSix/non-managed though?

[DioEgizio]

I mean the problem is that there's a modpack section even on onesix instances

[Trial97]

@DioEgizio have a look at: #1732 this should be an alternative to this PR

[Trial97]

Closing this in favor of:#1732