New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Modpack-page to instances that were created from files #1732
Conversation
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
This PR and #1727 are self-exclusive once one is accepted the other one should be closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i personally prefer this approach over the other one but idk what the other mantainers think
Regarding the ui: the button is gigantic but I have zero talent for UX can you suggest an alternative(a mockup) |
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits. |
Parrent PR: #1405
should fix: #1394 (comment)
From that comment looks like I did not fix the original issue just extended the functionality of the managed packs(downloaded through prism from modrinth/curseforge)
This PR aims to have a page for local packs (imported from files).
This only works with CurseForge and Modrinth packs.
How to test:
Also fixes #1731
fixes #1813