Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Modpack-page to instances that were created from files #1732

Merged
merged 4 commits into from Dec 11, 2023

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Oct 19, 2023

Parrent PR: #1405
should fix: #1394 (comment)
From that comment looks like I did not fix the original issue just extended the functionality of the managed packs(downloaded through prism from modrinth/curseforge)
This PR aims to have a page for local packs (imported from files).
This only works with CurseForge and Modrinth packs.

How to test:

download a modrinth pack( an older version)
install it using the mrpack file
download a newer version of the pack(outside of prism)
click edit instance on the created instance
you should have a similar page as when that pack would be downloaded through prism
entering that page you will be greeted with:
    the pack name(the name of the instance)
    a big button with upload from file
    a changelog that explains this is a local pack and can only be updated through respective format
click on the upload from file
select the new version
profit

Also fixes #1731
fixes #1813

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added bug Something isn't working simple change changelog:merged A PR that will be merged into a parent PR in the changelog labels Oct 19, 2023
@Trial97
Copy link
Member Author

Trial97 commented Oct 19, 2023

This PR and #1727 are self-exclusive once one is accepted the other one should be closed.

Copy link
Member

@DioEgizio DioEgizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i personally prefer this approach over the other one but idk what the other mantainers think

@Trial97 Trial97 added this to the 8.1 milestone Oct 22, 2023
@Trial97
Copy link
Member Author

Trial97 commented Oct 22, 2023

Regarding the ui: the button is gigantic but I have zero talent for UX can you suggest an alternative(a mockup)
Also regarding on a way to link to a modrinth/curseforge pack a solution can be found in: hhttps://github.com//pull/1414 where once you import a file we try to detect if is a curseforge/modrinth pack and if yes just make it one(right now works only for modrinth)

@Scrumplex Scrumplex added the backport release-8.x Backport PR automatically label Dec 11, 2023
@Scrumplex Scrumplex merged commit f8a6a09 into PrismLauncher:develop Dec 11, 2023
32 checks passed
Copy link
Contributor

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

Scrumplex added a commit that referenced this pull request Dec 11, 2023
@Scrumplex Scrumplex added manual backport PRs that have been backported manually and removed backport release-8.x Backport PR automatically labels Dec 11, 2023
LunaisLazier pushed a commit to LunaisLazier/ShatteredPrism that referenced this pull request Feb 9, 2024
@Scrumplex Scrumplex changed the title feat: added managed pack page for packs created from file Add Modpack-page to instances that were created from files Mar 3, 2024
@Scrumplex Scrumplex added changelog:added A PR that appears under "Added" in the changelog and removed changelog:merged A PR that will be merged into a parent PR in the changelog labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog:added A PR that appears under "Added" in the changelog manual backport PRs that have been backported manually simple change
Projects
None yet
3 participants