Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple dependency check from updating mods #1746

Merged
merged 9 commits into from Nov 17, 2023

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Oct 23, 2023

Added a button to check for updates and missing dependencies.
And kept the original button just to update the mods.
fixes #1745
fixes #1814

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added enhancement New feature or request simple change changelog:changed A PR that appears under "Changed" in the changelog labels Oct 23, 2023
@Trial97 Trial97 added this to the 8.1 milestone Oct 23, 2023
@getchoo getchoo modified the milestones: 8.1, 8.0 Nov 5, 2023
@getchoo
Copy link
Member

getchoo commented Nov 5, 2023

i don't see any reason why this needs to wait til 8.1. works as intended in my testing

@Trial97
Copy link
Member Author

Trial97 commented Nov 5, 2023

I added most of my new PRs to that milestone so I do not slow down the release of 8.0

@TheKodeToad
Copy link
Member

I don't like this implementation, because there will be too many buttons :catquake:

@Trial97
Copy link
Member Author

Trial97 commented Nov 5, 2023

I'm okay with removing this from milestone in favor of #1768 or #1796

@TheKodeToad TheKodeToad removed this from the 8.0 milestone Nov 6, 2023
 into toggle_deps

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97
Copy link
Member Author

Trial97 commented Nov 7, 2023

I don't like this implementation, because there will be too many buttons :catquake:

Then you will love what I did to it now (you have fewer visible buttons)

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Madis0
Copy link

Madis0 commented Nov 8, 2023

Should dependencies even be conceptually linked to updates?

As a user, I would maybe assume to find it in the mod addition window instead. For example, I pick a couple mods and there is a button to pick the mods' dependencies for me as well. Though that would not cover existing instance use cases so I'm not fully sure.

Edit: considering 8.0 already does kind of what I suggested (without showing dependencies as I pick mods), then that use case is already covered and this PR's menu can be added for existing instance use cases, indeed.

@Trial97
Copy link
Member Author

Trial97 commented Nov 8, 2023

It is linked to updates because you can have missing dependencies and you will want to check that (by other means than downloading all mods again through the mod download dialog).
With this PR though the default button will only update(without deps) and there will be a submenu for the dependency check.

@Desoroxxx
Copy link
Contributor

Desoroxxx commented Nov 8, 2023

Should dependencies even be conceptually linked to updates?

Mods can add new dependencies with updates.

Trial97 and others added 2 commits November 13, 2023 09:23
Co-authored-by: TheKodeToad <TheKodeToad@proton.me>
Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added this to the 8.1 milestone Nov 17, 2023
@Trial97 Trial97 merged commit 1150249 into PrismLauncher:develop Nov 17, 2023
31 checks passed
@Trial97 Trial97 deleted the toggle_deps branch November 17, 2023 19:42
@Scrumplex Scrumplex added the manual backport PRs that have been backported manually label Nov 28, 2023
LunaisLazier pushed a commit to LunaisLazier/ShatteredPrism that referenced this pull request Feb 9, 2024
separated dependecy check from mod update
@Scrumplex Scrumplex changed the title separated dependecy check from mod update Decouple dependency check from updating mods Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed A PR that appears under "Changed" in the changelog enhancement New feature or request manual backport PRs that have been backported manually simple change
Projects
None yet
6 participants