New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple dependency check from updating mods #1746
Conversation
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
i don't see any reason why this needs to wait til 8.1. works as intended in my testing |
I added most of my new PRs to that milestone so I do not slow down the release of 8.0 |
I don't like this implementation, because there will be too many buttons :catquake: |
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Then you will love what I did to it now (you have fewer visible buttons) |
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Should dependencies even be conceptually linked to updates? As a user, I would maybe assume to find it in the mod addition window instead. For example, I pick a couple mods and there is a button to pick the mods' dependencies for me as well. Though that would not cover existing instance use cases so I'm not fully sure. Edit: considering 8.0 already does kind of what I suggested (without showing dependencies as I pick mods), then that use case is already covered and this PR's menu can be added for existing instance use cases, indeed. |
It is linked to updates because you can have missing dependencies and you will want to check that (by other means than downloading all mods again through the mod download dialog). |
Mods can add new dependencies with updates. |
Co-authored-by: TheKodeToad <TheKodeToad@proton.me> Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
separated dependecy check from mod update
Added a button to check for updates and missing dependencies.
And kept the original button just to update the mods.
fixes #1745
fixes #1814