Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to disable resolving dependencies when installing mods #1768

Merged
merged 2 commits into from Jan 18, 2024

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Oct 30, 2023

Similar to: #1746
fixes #1818
But this is on the review message widget and allows the user to deselect(toggle) all dependencies

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added enhancement New feature or request simple change changelog:added A PR that appears under "Added" in the changelog labels Oct 30, 2023
@Trial97 Trial97 added this to the 8.1 milestone Oct 30, 2023
@TheKodeToad
Copy link
Member

It'd be nice to get a global toggle too - maybe before 8.0 because there are still some issues (can they be fixed though?)!

@Trial97
Copy link
Member Author

Trial97 commented Nov 1, 2023

Should I open a different PR for the toggle? Do we have a place in settings where I can slap that setting?

The only issue with dependencies that I saw is the fact that we can't match mods between providers(or the installed mods do not have meta). I will have a look at this until the end of the week. But please do not hold the 8.0 release for that.

Did I miss any other issues with dependencies?

@Scrumplex Scrumplex added the backport release-8.x Backport PR automatically label Dec 11, 2023
@Scrumplex Scrumplex merged commit bc75bcd into PrismLauncher:develop Jan 18, 2024
32 checks passed
Copy link
Contributor

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

Scrumplex added a commit that referenced this pull request Jan 18, 2024
@Scrumplex Scrumplex added manual backport PRs that have been backported manually and removed backport release-8.x Backport PR automatically labels Jan 18, 2024
@Scrumplex Scrumplex changed the title feat:added button to disable dependencies on the mod review Add button to disable resolving dependencies when installing mods Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added A PR that appears under "Added" in the changelog enhancement New feature or request manual backport PRs that have been backported manually simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency checking for updates is completely broken
4 participants