Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resizing columns of mod and other resource pages #1849

Merged
merged 1 commit into from Nov 17, 2023

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Nov 14, 2023

fixes #1811
and also made columns interactible(except the name that is streching)

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added enhancement New feature or request simple change changelog:added A PR that appears under "Added" in the changelog labels Nov 14, 2023
Copy link
Member

@TayouVR TayouVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works 👍

Only problem is that you need to grab the right columns on the right side even though it doesn't make sense, which was what I described as the main issue with this on discord recently.
Not much we can do about that though; Qt jank. Heres hoping table/list views are better in QML. 🤞

@Trial97 Trial97 added this to the 8.1 milestone Nov 16, 2023
@TayouVR TayouVR merged commit b5f8054 into PrismLauncher:develop Nov 17, 2023
34 of 40 checks passed
@Trial97 Trial97 linked an issue Nov 25, 2023 that may be closed by this pull request
1 task
@Scrumplex Scrumplex added the manual backport PRs that have been backported manually label Nov 28, 2023
LunaisLazier pushed a commit to LunaisLazier/ShatteredPrism that referenced this pull request Feb 9, 2024
@Scrumplex Scrumplex changed the title Made resource columns resizable Allow resizing columns of mod and other resource pages Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added A PR that appears under "Added" in the changelog enhancement New feature or request manual backport PRs that have been backported manually simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top bar size saves per instance Allow for resizing of columns in instance settings
4 participants