Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resetting settings when saving #1857

Merged
merged 3 commits into from Dec 11, 2023
Merged

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Nov 16, 2023

fixes #1856
And most probably other issues where the setting was reset but persisted on save.

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added bug Something isn't working simple change changelog:fixed A PR that appears under "Fixed" in the changelog labels Nov 16, 2023
@Trial97 Trial97 added this to the 8.1 milestone Nov 16, 2023
@TheKodeToad
Copy link
Member

I haven't tested but this probably causes the state of columns being shown/hidden to be reset in some cases.

@Trial97
Copy link
Member Author

Trial97 commented Nov 16, 2023

I haven't tested but this probably causes the state of columns being shown/hidden to be reset in some cases.

It shouldn't. The clear happens on the written-in file settings, but their value should already be in memory as we want to write them, so unless we reset the setting that will not happen(also from my testing I could not reproduce it).
Please test it out but this should have no implication for the column state.
For column stuff look here: #1849

@TheKodeToad
Copy link
Member

Oh, it should be fine. Unregistered settings will still be preserved, right?

@Trial97
Copy link
Member Author

Trial97 commented Nov 16, 2023

Unregistered settings will still be preserved, right?

So long they were saved before yes.
This PR only brings back the old functionality where on save the file was replaced instead of merged.

@Trial97 Trial97 changed the title fixed settings saving fixed settings not reseting on save Nov 17, 2023
@Scrumplex Scrumplex added the backport release-8.x Backport PR automatically label Dec 11, 2023
@Scrumplex Scrumplex merged commit bcaeab1 into PrismLauncher:develop Dec 11, 2023
32 checks passed
Copy link
Contributor

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

Scrumplex added a commit that referenced this pull request Dec 11, 2023
@Scrumplex Scrumplex added manual backport PRs that have been backported manually and removed backport release-8.x Backport PR automatically labels Dec 11, 2023
LunaisLazier pushed a commit to LunaisLazier/ShatteredPrism that referenced this pull request Feb 9, 2024
@Scrumplex Scrumplex changed the title fixed settings not reseting on save Fix resetting settings when saving Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog:fixed A PR that appears under "Fixed" in the changelog manual backport PRs that have been backported manually simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Keep play time" in instance copying is ignored
3 participants