New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resetting settings when saving #1857
Conversation
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
I haven't tested but this probably causes the state of columns being shown/hidden to be reset in some cases. |
It shouldn't. The clear happens on the written-in file settings, but their value should already be in memory as we want to write them, so unless we reset the setting that will not happen(also from my testing I could not reproduce it). |
Oh, it should be fine. Unregistered settings will still be preserved, right? |
So long they were saved before yes. |
Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits. |
fixes #1856
And most probably other issues where the setting was reset but persisted on save.