Added mod reinstall dialog #1892
Conversation
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Trial97
added
enhancement
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
There was a problem hiding this comment.
i'd recommend the button's name be changed to "change version" similar to the in version tab of instance settings - since that's a bit more descriptive, while "reinstall mod" sounds more like a troubleshooting method in the case a mod was installed incorrectly. it would also probably be nicer to have it near "check for updates" because of their similar functions
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
|
@getchoo other than java this is the last PR that you need to explicitly pay attention to. |
There was a problem hiding this comment.
code looks good and this works as expected
i did notice something during testing though: when modpacks are installed, it seems no metadata is fetched along with it. this in turn causes this feature to be unavailable until the user does something to cause metadata fetching manually like checking for updates. this is obviously out of scope for this PR, but probably something to come back to in the future
|
That is already tracked in this issue:#1730 |
fixes #1354
Added one more button to the mods page that will open a dialog with the selected mod allowing you to select a new version to install.
Also added a tag to the installed version combobox to determine what is the installed version.