-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the maximized option on the newer Minecraft versions #1894
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Do you have more than one monitor? |
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
With the latest commit the decoration size should also be taken into consideration. |
I have 3 monitors, though the size of the gap is the size of the window title bar. The task bar is about twice that size. |
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
I can't control the window at all (size being the exception as we have some arguments for it) so the position change I believe is something not for this PR(maybe possible but I will not worry about it). |
I assume you mean you're not entirely sure. It should be available, but in newer Minecraft versions (with LWJGL3) I'm pretty sure it causes some big problems! |
Do not worry I removed that in favor of some c++ code that does the same thing but a little better: 0cab57c
The only reason I opted to also add a warning on the checkbox is because in theory even if the surface of the game is expanded at maximum(similar to how maximized would work) is not maximized. |
fixes #181
closes #292
Works on my machine but I would want to test it against other platforms
This doesn't really start it in maximized mode but just sets the game width and height to the maximum possible value.
Warning I'm entirely sure thatjava.awt
stuff is in the default java installation(I haven't worked with java for a long time)