Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrpack import should consider server files #2142

Closed
wants to merge 1 commit into from

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Feb 19, 2024

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added simple change changelog:changed A PR that appears under "Changed" in the changelog labels Feb 19, 2024
@TheKodeToad TheKodeToad added this to the 8.1 milestone Feb 19, 2024
@Trial97 Trial97 closed this Feb 19, 2024
@TheKodeToad TheKodeToad removed this from the 8.1 milestone Feb 19, 2024
@TheKodeToad
Copy link
Member

TheKodeToad commented Feb 19, 2024

image

I think there was perhaps some confusion between Modrinth projects and Mrpack files. A Modrinth moderator said that projects should be marked as "unsupported" on the client if they do not affect it.

However - if you think about it, it would make no sense in the modpack format if setting client to unsupported behaved the same way as required. This behaviour also is different to Modrinth's own launcher and documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed A PR that appears under "Changed" in the changelog simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants