Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several Modrinth export fixes #2178

Merged
merged 2 commits into from Mar 3, 2024
Merged

Several Modrinth export fixes #2178

merged 2 commits into from Mar 3, 2024

Conversation

TheKodeToad
Copy link
Member

@TheKodeToad
Fix server side mods being marked as unsupported on client
138df66 
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
@TheKodeToad TheKodeToad added the bug Something isn't working label Mar 1, 2024
@TheKodeToad TheKodeToad added this to the 8.1 milestone Mar 1, 2024
@TheKodeToad
Allow multiline description
4101fbb 
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
Trial97
Trial97 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@Trial97 Trial97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The export part is a little shady for me but if you say it works lgtm!

@TheKodeToad
Copy link
Member Author

Could you elaborate?

@Trial97
Copy link
Member

Trial97 commented Mar 1, 2024

This is related to a discussion that we had previously: https://discord.com/channels/1031648380885147709/1209079645815967805 and #2142
In that discussion, we concluded that the mod is incorrectly marked as server-side only and we do not need to make any changes to the import and export.
Maybe I'm overthinking stuff but I still believe that the mrpack implementation we have is correct: like that mod is server-side mod why it is exported as needed for the client?
If we consider changing the export as such we should consider also changing the import like I did in the mentioned PR.

@TheKodeToad
Copy link
Member Author

Your other PR clearly went against Modrinth's specification. This does not.

@TayouVR TayouVR added changelog:fixed A PR that appears under "Fixed" in the changelog backport release-8.x Backport PR automatically labels Mar 3, 2024
@TayouVR TayouVR changed the title (More) mrpack fixes (More) mrpack export fixes Mar 3, 2024
@TayouVR TayouVR merged commit 1627f3c into PrismLauncher:develop Mar 3, 2024
33 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Successfully created backport PR for release-8.x:

@github-actions github-actions bot mentioned this pull request Mar 3, 2024
Merged
@Scrumplex Scrumplex changed the title (More) mrpack export fixes Several Modrinth export fixes Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TayouVR TayouVR TayouVR approved these changes

@Trial97 Trial97 Trial97 approved these changes

@DioEgizio DioEgizio DioEgizio approved these changes

Assignees
No one assigned
Labels
backport release-8.x Backport PR automatically bug Something isn't working changelog:fixed A PR that appears under "Fixed" in the changelog
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.

Allow multiple lines summary in Modrinth pack
4 participants
@TheKodeToad @Trial97 @TayouVR @DioEgizio