Better Tasks

[Ryex]

Better Tasks:

• Tasks have UUIDs

  • easier to track in logs
  • can better track data related to them (like when propagating progress of child tasks)

• ProgressDialog has been revamped to report child task progress and status details (ie download speed)

• all existing tasks have been updated to propagate the progress of their child tasks

  • this mean download progress and speed is reported for effectively everything.
    • or at least it would if QNetwork Replies reported total download size. for now only speed works.

• add loading of logging rules from a qtlogging.ini file at the Prism data path root.
  an example file

[Rules]
# remove the debug lines, other log levels still get through
launcher.task.net.download.debug=false
# enable or disable whole catagories
launcher.task.net=true
launcher.task=false
launcher.task.net.upload=true

bettertasks_pack_download.webm

bettertasks_assets_download.webm

[Scrumplex]

(apart from my comments above, excellent work so far!)

[Ryex]

ok, ready for a more in depth review. I feel good about what I've achieved with this in terms of QOL changes.

[Ryex]

ugg, why are some of the QT6 task test's failing....

[DioEgizio]

there's something wrong in this pr (doesn't happen in develop)

[DioEgizio]

d4297b7 is the last commit where this doesn't happen, i suppose it's caused by that ini file

[Ryex]

d4297b7 is the last commit where this doesn't happen, i suppose it's caused by that ini file

What the... This is MacOS?

[DioEgizio]

I'm on macOS ye

[Ryex]

time to load up my VM then....

[Ryex]

there's something wrong in this pr (doesn't happen in develop)

@DioEgizio I can't seem to replicate this on my VM. what configure args are you passing. does it actually load the qtlogging.ini file? (should be at the beginning of the logs)

[DioEgizio]

Did you try reproducing it building yourself or did you try the CI builds?

anyway there's a possibility the latest develop commit fixed this, so try just rebasing

[Ryex]

Did you try reproducing it building yourself or did you try the CI builds?

anyway there's a possibility the latest develop commit fixed this, so try just rebasing.

I was building myself with QT 6.5. hard to debug a ci-build. I'll try one now though.

[Ryex]

ok, yes, the CI builds do have it somewhat

[Ryex]

For the record enabling the logging category qt.qpa.drawing.debug causes theme artifacts on MacOS

[DioEgizio]

forgor to add but now everything works fine on macos

[Ryex]

updated

[TayouVR]

I think this was finished, right?
Just needs one more approval.
I'm not the most qualified, but in my eyes the code looks good.

[Ryex]

yep, this is finished

[flowln]

lgtm! sorry for the thousand comments on consecutive lines, github should allow me to merge those, but it doesn't 😔

[DioEgizio]

Conflicting with develop

[Ryex]

Woo! three approvals!