Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ninja in nix builds #966

Merged
merged 1 commit into from Apr 2, 2023
Merged

use ninja in nix builds #966

merged 1 commit into from Apr 2, 2023

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Apr 1, 2023

most of our ci already uses ninja, why not nix?

@getchoo
feat(nix): use ninja for builds
81b1406 
Signed-off-by: seth <getchoo@tuta.io>
@Scrumplex
Copy link
Member

We usually intend to keep our default.nix in sync with the package on nixpkgs. Maybe make a PR there as well to keep this in sync.

@Scrumplex Scrumplex added this to the 7.0 milestone Apr 1, 2023
@Scrumplex Scrumplex added enhancement New feature or request packaging Issues and PRs related to packaging (CI builds or package managers) simple change labels Apr 1, 2023
@getchoo
Copy link
Member Author

getchoo commented Apr 1, 2023

done NixOS/nixpkgs#224260

Minion3665
Minion3665 approved these changes Apr 1, 2023
View reviewed changes
Copy link
Contributor

@Minion3665 Minion3665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review isn't in any way binding here, but I looked over the similar PR for nixpkgs and believe this one should also go ahead

@txtsd txtsd merged commit bc1a7d2 into PrismLauncher:develop Apr 2, 2023
14 checks passed
@getchoo getchoo deleted the use-ninja branch April 10, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@txtsd txtsd txtsd approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

@Minion3665 Minion3665 Minion3665 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request packaging Issues and PRs related to packaging (CI builds or package managers) simple change
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@getchoo @Scrumplex @txtsd @Minion3665