Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prismlauncher: use ninja #224260

Merged
merged 1 commit into from
Apr 2, 2023
Merged

prismlauncher: use ninja #224260

merged 1 commit into from
Apr 2, 2023

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Apr 1, 2023 •
edited

Description of changes

use ninja as a build generator over make, in order to follow upstream

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@getchoo getchoo mentioned this pull request Apr 1, 2023
Merged
Scrumplex
Scrumplex approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Logs show that Ninja is being used to build.

Result of nixpkgs-review pr 224260 run on x86_64-linux 1

2 packages built:
  • prismlauncher
  • prismlauncher-qt5

@ofborg ofborg bot requested review from Minion3665 and Scrumplex April 1, 2023 19:59
Minion3665
Minion3665 approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@Minion3665 Minion3665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, following upstream is always nice

@bobby285271 bobby285271 merged commit 4472348 into NixOS:master Apr 2, 2023
13 checks passed
@getchoo getchoo mentioned this pull request Apr 2, 2023
Merged
12 tasks
@getchoo getchoo deleted the patch-1 branch April 10, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@Minion3665 Minion3665 Minion3665 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12.approvals: 2 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@getchoo @Scrumplex @Minion3665 @bobby285271