Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xaml navigation without animation isn't working #1683

Closed
bares43 opened this issue Feb 8, 2019 · 7 comments
Closed

Xaml navigation without animation isn't working #1683

bares43 opened this issue Feb 8, 2019 · 7 comments

Comments

@bares43
Copy link
Contributor

bares43 commented Feb 8, 2019

Description

Hello, according this article http://brianlagunas.com/whats-new-prism-7-1/ XAML navigation should support Animated parameter. However, there is not such a parameter. I use Prism.Forms 7.1.0.431 and when I try to use this parameter a get the error "The property 'Animated' was not found in type 'NavigateToExtension'". I also checked the sources code https://github.com/PrismLibrary/Prism/blob/9d05095de2275898711b12c73ec157a4038649db/Source/Xamarin/Prism.Forms/Navigation/Xaml/NavigateToExtension.cs and there isn't any animated parameter. So how this is supposed to work?

Steps to Reproduce

  1. Install Prism.Forms 7.1.x
  2. Try to use XAML navigation without animation

Expected Behavior

Navigation without animation should work.

Actual Behavior

I cannot use animation parameter.

Basic Information

  • Version with issue: 7.1.0.431
  • Last known good version: unknown
  • Xamarin.Forms version: 3.5.0.129452
  • IDE: Visual Studio 15.8.8.
@bares43 bares43 changed the title Xaml navigation without animation isn Xaml navigation without animation isn't working Feb 8, 2019
@brianlagunas
Copy link
Member

Yeah, that was my fault because I used an old copy of the initial spec code snippets for the blog post. The final version of the feature did not have those properties in it. This will be considered an enhancement

@brianlagunas
Copy link
Member

For now, just create your own extension, add your desired properties, and then override HandleNavigation to modify the navigation call.

@bares43
Copy link
Contributor Author

bares43 commented Feb 8, 2019

Thanks for answer. I've already created my own extension but it would be better if this could handle Prism itself. :)

@brianlagunas
Copy link
Member

We accept PRs

@bares43
Copy link
Contributor Author

bares43 commented Feb 8, 2019

I guess I could try it

@bares43
Copy link
Contributor Author

bares43 commented Feb 8, 2019

So PR #1684 is created :)

@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants