Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xamarin forms xaml navigation animated #1684

Merged
merged 2 commits into from
Feb 11, 2019
Merged

xamarin forms xaml navigation animated #1684

merged 2 commits into from
Feb 11, 2019

Conversation

bares43
Copy link
Contributor

@bares43 bares43 commented Feb 8, 2019

Description of Change

  • XAML navigation animated parameter, issue Xaml navigation without animation isn't working #1683
  • Xamarin.Forms in sample app updated to 3.5., I wasn't able even compile the project because Prism.Forms has dependency on 3.5 and sample app had to 3.3
  • I didn't find any tests for this xaml extension

API Changes

Added:

  • bool NavigationExtensionBase.Animated

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dnfclas
Copy link

dnfclas commented Feb 8, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@bares43 bares43 mentioned this pull request Feb 8, 2019
Closed
@dansiegel dansiegel added the XF label Feb 9, 2019
@brianlagunas brianlagunas merged commit 9aaec2f into PrismLibrary:master Feb 11, 2019
@brianlagunas
Copy link
Member

Thanks for the new features!

@bares43
Copy link
Contributor Author

bares43 commented Feb 11, 2019

Thanks

@bares43 bares43 deleted the feature/XamlNavigationAnimated branch February 11, 2019 21:40
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brianlagunas brianlagunas brianlagunas approved these changes

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
XF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bares43 @dnfclas @brianlagunas @dansiegel