Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed property observer to use property info instead of property name #1680

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Conversation

omerfarukz
Copy link
Contributor

Bugs Fixed

#1676

PR Checklist

  • [x ] Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • [x ] Changes adhere to coding standard

@dnfclas
Copy link

dnfclas commented Feb 4, 2019

CLA assistant check
All CLA requirements met.

@brianlagunas
Copy link
Member

This is actually much better. Sometimes it's easy to miss the most obvious approach. Have you confirmed that this works for your scenario?

@omerfarukz
Copy link
Contributor Author

omerfarukz commented Feb 5, 2019

Yes, it works in my scenario. All tests are passed except DirectoryModuleCatalogFixture. Consedired it is not related with this.

@brianlagunas
Copy link
Member

Cool. Yeah, don't worry about the DirectoryModuleCatalog tests. Those are failing because of the .NET Core 3 target. We are working on our build server right now, so as soon as we get that fixed, I'll merge.

@dansiegel dansiegel merged commit 4403abb into PrismLibrary:master Feb 7, 2019
@dansiegel
Copy link
Member

Thanks for the PR

@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants