Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored parameter classes to use ParametersBase class #2085

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

brianlagunas
Copy link
Member

Description of Change

Refactored DialogParameters and NavigationParameters to derive from ParameterBase to eliminate code duplication.

Bugs Fixed

PR Checklist

  • Has tests (existing tests)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel merged commit 47dc850 into master Apr 23, 2020
@dansiegel dansiegel deleted the parameter-refactor branch April 23, 2020 18:01
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

1 similar comment
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants