Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DialogService improvements #2191

Merged
merged 2 commits into from
Sep 3, 2020
Merged

DialogService improvements #2191

merged 2 commits into from
Sep 3, 2020

Conversation

brianlagunas
Copy link
Member

@brianlagunas brianlagunas commented Sep 3, 2020 •
edited
Loading

Description of Change

Added a new virtual method to show the dialog window, and also added new extension methods to show a dialog without parameters

Bugs Fixed

API Changes

List all API changes here (or just put None), example:

Added:

  • void IDialogService.Show(name);
  • void IDialogService.Show(name, callback);
  • void IDialogService.ShowDialog(name);
  • void IDialogService.ShowDialog(name, callback);

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel self-requested a review September 3, 2020 20:39
@brianlagunas brianlagunas merged commit 2f81418 into master Sep 3, 2020
@brianlagunas brianlagunas deleted the dialog-improvements branch September 3, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
WPF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianlagunas @dansiegel