Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Make DialogService Show methods extensible #2184

Closed
brianlagunas opened this issue Aug 28, 2020 · 0 comments
Closed

[Enhancement] Make DialogService Show methods extensible #2184

brianlagunas opened this issue Aug 28, 2020 · 0 comments
Assignees
@brianlagunas
Labels
enhancement WPF
Milestone
Prism 8.0

Comments

@brianlagunas
Copy link
Member

brianlagunas commented Aug 28, 2020 •
edited
Loading

Summary

The current DialogService for WPF does not expose any methods that can be overriden to provide customization of the showing of a dialog. This was an oversight on my part.

API Changes

  • add a new Show method that can be overridden

Intended Use Case

This will provide the ability for developers to customize or change the functionality of the built-in dialog service.
@brianlagunas brianlagunas added this to the Prism 8.0 milestone Aug 28, 2020
@brianlagunas brianlagunas self-assigned this Aug 28, 2020
@brianlagunas brianlagunas changed the title [Enhancement] Make DialogService methods extensible [Enhancement] Make DialogService Show methods extensible Aug 31, 2020
@brianlagunas brianlagunas mentioned this issue Sep 3, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianlagunas brianlagunas

Labels
enhancement WPF
Projects
None yet
Milestone
Prism 8.0
Development

No branches or pull requests
1 participant
@brianlagunas