[Breaking] Removed auto initialize for nav parameters #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianlagunas
changed the title
dansiegel
approved these changes
Oct 15, 2020
|
Why was this removed? |
|
@PhilJenson this added a reflection lookup cost to every app & thus a perf hit that we really wanted to get rid of. The Magician accomplishes this intelligently at build time with Source Generation keeping you from having to write the boiler plate. If you're interested in that it's available to Sponsors on SponsorConnect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I have removed the reflection based auto initialize for navigation parameters feature.
API Changes
List all API changes here (or just put None), example:
Removed:
Behavioral Changes
If your code used this feature, it will no longer work. If you would still like to have this feature, you can contact @dansiegel about gaining access to his new Prism tooling called Magician which does this using a much better approach.
PR Checklist