Await task extensions fix

[Binderbound]

Description of Change

Changed TaskExtensions / TaskExtensions{T} to not trigger errorCallback if an exception is raised by completedCallback.

Bugs Fixed

#2804

API Changes

None

Behavioral Changes

Await will not trigger errorCallback if there is an error in completedCallback.

PR Checklist

• Has tests (if omitted, state reason in description)
• Rebased on top of master at time of PR
• Changes adhere to coding standard

[brianlagunas]

I'm not user I like swallowing the exceptions in the completed callback. If an error happens in the callback, the developer should be notified via an exception. if anything we should probably rethrow the exception

[Binderbound]

If I re-throw the exception, that would be an exception within an async void method that you're not awaiting, so you wouldn't see it, though it might crash the program.

[Binderbound]

I could make it a Task and make the calling methods run the task as a separate thread, but then they're still going to not be able to notify of the error.

[brianlagunas]

I'm curious if something like this would be better

            bool error = false;
            try
            {
                await task.ConfigureAwait(configureAwait);
            }
            catch (Exception ex)
            {
                error = true;
                errorCallback?.Invoke(ex);
            }
            finally
            {
                if (!error)
                    completedCallback?.Invoke();
            }

[brianlagunas]

@Binderbound did you see my suggestion? Thoughts?

[dansiegel]

@Binderbound I'm closing this as there has been no activity on it for quite a while now. We welcome your contribution though. If you would like to follow up with the updates that were requested by @brianlagunas we can look at reopening this.