add enchantments from wiki

[uncovery]

generated with this code PrismarineJS/minecraft-wiki-extractor#27

[uncovery]

Seems there is a required format for enchantments that I was not aware of.
Seems to be defined here: https://github.com/PrismarineJS/minecraft-data/blob/master/schemas/enchantments_schema.json

Since we have more information than that, can we change the schema instead of limiting the data availability? What is depending on that schema?

[rom1504]

Mineflayer is using that schema for example. If you can add property without changing current properties it's good.

[uncovery]

Ok, sounds reasonable. Question:

how can we make sure the unique integer ID is consistent? This ID has been deprecated and now it's the name string (e.g. minecraft:efficiency). While we can take the old ID for the old enchantments, new enchantments (for crossbows, tridents etc) do not have an ID anymore and any assignment would be completely arbitrary. We can of course just assign one in a central place, but I would prefer & suggest that we use the enchantment name as ID since it's already unique. Otherwise we have to take it out since it's supposed to be unique and we cannot have 2 entries with a 0 in there. My commit below will work in any case, I can just fill in a sequential number. But that one will then likely change with the next MC release.

"id": {
        "description": "The unique identifier for an enchantment",
        "type": "integer",
        "minimum": 0
      },

I am adding a pull request below for a schema proposal, please help me verify this

[rom1504]

I can't find any place in prismarinejs where we use the enchantments.
Do you have an use case in mind ?
What packets would this be used with for example ?

[Karang]

I can't find any place in prismarinejs where we use the enchantments.
Do you have an use case in mind ?
What packets would this be used with for example ?

It would be useful to have that in mineflayer because enchantments can affect some properties:

• dig time is affected by the tool enchantment
• fall damages is affected by Protection and Feather falling enchantments

Also having this data could be useful to make the bot work with enchantment tables ?

Eventually enchantments would be implemented in flying-squid ?

[rom1504]

Yeah, so same question then, if we want to use them in client/server, which packet is it ?
That'll make it possible to answer what data we need

[rom1504]

Ok so the answer is for example https://wiki.vg/Protocol#Window_Property

As you can see the numerical IDs are still used and not deprecated at all.

So we do need them.

The wikis removing them means end users may not need them, so I guess you'd need to find these IDs elsewhere. (The jar I guess ? Have a look at burger extractor maybe)

[uncovery]

Ok so the answer is for example https://wiki.vg/Protocol#Window_Property

Ok, did not know that. Will take a look how to get them then.

[uncovery]

Do you have an use case in mind ?

My use case for example is that I can now make sure that a system that dishes out random enchanted items as rewards does create any that violate the enchantment conflicts. Further it's used to display the transactions of my servers' in-game shop properly with enchantments on the servers website.

[uncovery]

I can't find any place in prismarinejs where we use the enchantments.

I am a bit confused why this question is being asked. While I can understand that you guys want to have the enchantments be done properly (with the IDs and fitting here to the data schema etc, I would like to know what other prerequisites this needs - beyond just working. I have started doing this here instead of in my own systems mainly because there was already an older version doing exactly that, I am merely updating it.

If there is a requirement to have an active use in prsimarineJS or some such, then I'd rather drop the ball here and re-do it in my own system instead. I have fulfilled my own requirements on this functionality a week ago and everything further from now on is done 100% to satisfy other people's needs. In case there is no such need, please let me know ASAP so I can focus my time on more productive things.

I know I am poor at programming and sorry if my mistakes and shortcomings are creating additional work. If it's not even achieving anything once it's done, this does not make any sense at all. Sorry if this sounds like a rant, I do not mean to be guilt-tripping people into liking what I do. If you do not see a use case, just tell me and I'll move on without hard feelings.