Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 1.13+ physics #12

Merged
merged 10 commits into from
Aug 13, 2020
Merged

Improve 1.13+ physics #12

merged 10 commits into from
Aug 13, 2020

Conversation

IdanHo
Copy link
Member

@IdanHo IdanHo commented Aug 10, 2020 •
edited

  • Implements bubble columns
  • Makes the water detection recognize bubble columns as still water blocks
  • Makes the water detection recognize waterlogged blocks as still water blocks
  • Fix MC 1.13+ gravity in water and lava
  • Implements honeyblocks
  • Implements all physics related effects (JumpBoost, Speed, Slowness, Dolphin's Grace, Slow Falling, Levitation)
  • Implements Depth Strider enchantment (NOTE: currently missing the soul speed enchantment due to it missing from mc-data, see Missing new 1.16.0 enchantment minecraft-data#325, will open a pr there soon)
  • Fixed soulsand slowness being applied multiple times when standing on the edge between 2 soulsand blocks

fixes #11 & fixes #6

Karang
Karang requested changes Aug 10, 2020
View reviewed changes
Copy link
Collaborator

@Karang Karang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, I left some comments, but I cannot test it before tomorrow.

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
Karang
Karang reviewed Aug 10, 2020
View reviewed changes
Copy link
Collaborator

@Karang Karang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@IdanHo
Optimizations
d0dbc81
@IdanHo
Implement missing isOffsetPositionInLiquid (1.8 - 1.12) / doesNotColl…
a38fca3 
…ide (1.13 - 1.16)
@IdanHo
New features and fixes
c88f2be 
Implemented honeyblocks, implemented 1.13+ lava gravity, Fixed soulsand slowness being applied multiple times, implemented depth strider, implemented levitation, slowfalling, dolphin's grace, slowness, speed, jump boost
@IdanHo IdanHo changed the title Improve 1.13+ water physics Improve 1.13+ physics Aug 11, 2020
@IdanHo IdanHo requested a review from Karang August 11, 2020 00:46
@rom1504 rom1504 added this to Needs triage in PR Triage Aug 12, 2020
@rom1504
Copy link
Member

rom1504 commented Aug 12, 2020

I'll let @Karang handle this one

Karang
Karang reviewed Aug 12, 2020
View reviewed changes
index.js Outdated Show resolved Hide resolved
Karang
Karang reviewed Aug 12, 2020
View reviewed changes
index.js Outdated Show resolved Hide resolved
Karang
Karang approved these changes Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@Karang Karang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Karang Karang merged commit e9ea19d into PrismarineJS:master Aug 13, 2020
PR Triage automation moved this from Needs triage to Closed Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OldStarchy OldStarchy OldStarchy left review comments

@Karang Karang Karang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR Triage
  
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bot can't ride bubble elevators Implement Jump potion effect
4 participants
@IdanHo @rom1504 @Karang @OldStarchy