Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement #105

Closed
rom1504 opened this issue Dec 29, 2020 · 3 comments
Closed

Performance improvement #105

rom1504 opened this issue Dec 29, 2020 · 3 comments

Comments

@rom1504
Copy link
Member

rom1504 commented Dec 29, 2020

Is there anything we can do so it's faster to render chunks?
https://prismarine.js.org/prismarine-viewer/standalone/
Things that can be improved:

  • loading time: it takes about 30s to have the render being finished for the first time
  • new rendering: when moving the view, it takes again about 30s to having the render being complete

This is a limitation in particular when trying to increase the view size to render many things.

What could be done to have this be done faster? (even if lowering the quality, that could be a setting)

@Karang
Copy link
Collaborator

Karang commented Dec 29, 2020

the problem is mainly the generation:

  • its filling air chunks
  • its done in the main thread

It shouldn't be too hard to do better: https://github.com/PrismarineJS/prismarine-viewer/blob/master/examples/standalone/index.js#L33

@rom1504
Copy link
Member Author

rom1504 commented Dec 29, 2020 via email

@rom1504
Copy link
Member Author

rom1504 commented Jan 2, 2021

now good enough by adding setTimeout so the main thread is not blocked

@rom1504 rom1504 closed this as completed Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants