Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to localy test this package? #99

Closed
3top1a opened this issue Dec 23, 2020 · 24 comments
Closed

How to localy test this package? #99

3top1a opened this issue Dec 23, 2020 · 24 comments

Comments

@3top1a
Copy link
Contributor

3top1a commented Dec 23, 2020

I wanted to do #57, but I don't know how to test/run the package localy.
Any help?

@rom1504
Copy link
Member

rom1504 commented Dec 23, 2020 via email

@3top1a
Copy link
Contributor Author

3top1a commented Dec 23, 2020

My changes are still not visible, i tried removing the players color in entities.js, I can still se it in red

@rom1504
Copy link
Member

rom1504 commented Dec 23, 2020 via email

@3top1a
Copy link
Contributor Author

3top1a commented Dec 23, 2020

How?
(Sorry for my inexperience)

@rom1504
Copy link
Member

rom1504 commented Dec 23, 2020 via email

@3top1a
Copy link
Contributor Author

3top1a commented Dec 23, 2020

Still nothing

@rom1504
Copy link
Member

rom1504 commented Dec 23, 2020 via email

@3top1a
Copy link
Contributor Author

3top1a commented Dec 23, 2020

examples/bot.js

@rom1504
Copy link
Member

rom1504 commented Dec 23, 2020 via email

@3top1a
Copy link
Contributor Author

3top1a commented Dec 23, 2020

There is a public/
Log:

ℹ 「wds」: Project is running at http://localhost:8080/
ℹ 「wds」: webpack output is served from undefined
ℹ 「wds」: Content not from webpack is served from /home/not-a-weeb/Documents/mineflayer/prismarine-viewer
ℹ 「wdm」: wait until bundle finished: /
ℹ 「wdm」: asset ./index.js 1.98 MiB [emitted] (name: main)
runtime modules 1010 bytes 5 modules
modules by path ./node_modules/ 1.74 MiB 60 modules
modules by path ./viewer/ 16.9 KiB
  ./viewer/index.js 186 bytes [built] [code generated]
  ./viewer/lib/viewer.js 2.59 KiB [built] [code generated]
  ./viewer/lib/worldView.js 4.18 KiB [built] [code generated]
  ./viewer/lib/simpleUtils.js 1.21 KiB [built] [code generated]
  ./viewer/lib/worldrenderer.js 4.47 KiB [built] [code generated]
  ./viewer/lib/entities.js 1.35 KiB [built] [code generated]
  ./viewer/lib/primitives.js 1.25 KiB [built] [code generated]
  ./viewer/lib/version.js 714 bytes [built] [code generated]
  ./viewer/lib/utils.electron.js 512 bytes [built] [code generated]
  ./viewer/lib/utils.js 512 bytes [built] [code generated]
./lib/index.js 1.86 KiB [built] [code generated]
./public/supportedVersions.json 100 bytes [built] [code generated]
webpack 5.11.0 compiled successfully in 3755 ms

asset ./worker.js 16 MiB [emitted] (name: main)
416 modules
webpack 5.11.0 compiled successfully in 5903 ms
ℹ 「wdm」: Compiled successfully.

@rom1504
Copy link
Member

rom1504 commented Dec 23, 2020 via email

@3top1a
Copy link
Contributor Author

3top1a commented Dec 23, 2020

node examples/bot.js

Yes, i made the character box have a green color.
It still has red

@rom1504
Copy link
Member

rom1504 commented Dec 23, 2020 via email

@Karang
Copy link
Collaborator

Karang commented Dec 23, 2020

How did you change it ?

@3top1a
Copy link
Contributor Author

3top1a commented Dec 23, 2020

Just give me a list of commands to build and test the package, I'll just copy the files

@rom1504
Copy link
Member

rom1504 commented Dec 23, 2020 via email

@3top1a
Copy link
Contributor Author

3top1a commented Dec 23, 2020

For anyone else (me included), just list the steps necesary to extend this module

@rom1504
Copy link
Member

rom1504 commented Dec 23, 2020

Yes. What are you confused about what I just said ?
Maybe you could come to our discord, I guess it would be easier to communicate there.

@3top1a
Copy link
Contributor Author

3top1a commented Dec 23, 2020

By the fact it still doesn't work

@extremeheat
Copy link
Member

What doesn’t work? What’s the error? What happens? What have you tried? Can’t help you if you’re not more specific.

@3top1a
Copy link
Contributor Author

3top1a commented Dec 23, 2020

I have made a change in the entity.js file, making the player character green.
No matter what I tried, it's still red.

What I tried:

  • npm link
  • yarn add
  • everything in this thread

@extremeheat
Copy link
Member

Can you join the discord? It may be easier to help there. What changes did you make?

@3top1a
Copy link
Contributor Author

3top1a commented Dec 23, 2020

What room?

@Karang
Copy link
Collaborator

Karang commented Dec 24, 2020

If you want to change the bot color you need to edit https://github.com/PrismarineJS/prismarine-viewer/blob/master/lib/index.js#L61

The code in entities.js is for other players. Ultimately this would need to be refactored to share some code.

@Karang Karang closed this as completed Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants