Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/50 test framework #68

Merged
merged 5 commits into from
Apr 29, 2016
Merged

Feature/50 test framework #68

merged 5 commits into from
Apr 29, 2016

Conversation

kaievns
Copy link
Contributor

@kaievns kaievns commented Apr 29, 2016

So, this pretty chunky thing closes several issues

  1. Update test framework - replace Tape with Mocha #50 replaces tape with mocha
  2. Change assert statements in tests to use Must #63 changes all assertions to use must consistently with the should syntax
  3. Test files should have _test suffix #41 makes all test files automatically have the _test suffix
  4. Generated project structure #45 + Naming convention of things #2 renames the tests/ -> test/
  5. adds the test/mocha.opts file as a standard way to configure mocha within projects
  6. makes tests awesome again

@@ -0,0 +1,37 @@
const fetch = require('node-fetch');
const jwt = require('jsonwebtoken');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to align assignments? This is probably one of "those" conversations, but we haven't done that on any other projects so to be safe I think let's not introduce the style here, but let's discuss it.

Copy link
Contributor Author

@kaievns kaievns Apr 29, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nwinch
Copy link
Contributor

nwinch commented Apr 29, 2016

@madrabbit Review done with just a couple of minor things. Lovely stuff. LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants