Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.0 Update #1

Merged
merged 7 commits into from
Sep 16, 2023
Merged

1.1.0 Update #1

merged 7 commits into from
Sep 16, 2023

Conversation

KrLite
Copy link
Contributor

@KrLite KrLite commented Sep 4, 2023

Warning

This update is targeting for Minecraft 1.20~1.20.1. Please make a copy of the current branch, rename it to fabric/1.20 (as suggested) and migrate this pull request's base to that branch before merging.

Updates

Versioning

  • Update to target Minecraft 1.20~1.20.1
  • Update to version 1.1.0
  • Update Gradle: 7.68.1.1
  • Update Fabric Loom: 1.0-SNAPSHOT1.3-SNAPSHOT
  • Update Fabric Loader: 0.14.60.14.22

Contents

  • The pings can now be triggered not only in the remote server but also in the integrated server.
    Reason Sometimes player use their clients as LAN servers. I believe the pings should still work under such situation instead of responding nothing.
  • The pings are now colored.
    Reason Implemented as a planned feature.
    Details@everyone is colored with 0xFFCB25 (kinda yellow) while @... is colored with 0xFF52D0 (kinda magenta-pink). The colors are stored together within a straightforward HashMap<Pattern, Integer> where the keys are regex patterns used to distinguish different ping styles.
  • The pings in chat lines are having hover and click events.
    Reason Implemented as a planned feature.
    Details Hovering @everyone shows a hint to ping everyone while hovering @... shows the player's display name and uuid. Clicking the pings will result in a chat suggestion started with the chosen ping action, for example, clicking on @everyone will open a new chat screen with @everyone (with a trailing space) pre-filled.

Localizations

  • Add key action.pingme.ping_everyone to existing localization files.
  • Add Japanese translation (ja_jp.json)

README.md

  • Use checkboxes in feature list.
  • Add a screenshot showing the colored pings and the action bar notification.
  • Suggest to install the mod client-side for better experiences.
  • Renew certain expressions.

@Flamarine Flamarine changed the base branch from fabric/1.19.3 to fabric/1.20 September 16, 2023 07:21
@Flamarine Flamarine merged commit 4bdb52d into Prismwork:fabric/1.20 Sep 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants