Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect and report on damaged pastes #1218

Merged
merged 2 commits into from
Dec 19, 2023
Merged

detect and report on damaged pastes #1218

merged 2 commits into from
Dec 19, 2023

Conversation

elrido
Copy link
Contributor

@elrido elrido commented Dec 16, 2023 •
edited

May occur during statistics or purge, when existing pastes get parsed, addresses #1214

Changes

  • Catch exceptions in statistics and around purging, report these as errors
  • Failure during purge should not prevent paste creation (unless the data folder is corrupt or otherwise not writable anymore)
  • Statistics will report each damaged paste ID and also include a count if any were found
  • Turn some basic exceptions into error_log messages - no point in getting a stack trace for them and exceptions will end up being reported in the same place. No point in throwing exceptions that no one will ever catch, either.

@elrido
detect and report on damaged pastes
d889456 
May occur during statistics or purge, when existing pastes get parsed, addresses #1214
@elrido
document change
a17529c
@elrido elrido merged commit 5458554 into master Dec 19, 2023
17 checks passed
@elrido elrido deleted the detect-broken-pastes branch December 19, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rugk rugk rugk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elrido @rugk