Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shortened paste URL does not appear in email #1264

Merged
merged 1 commit into from Mar 14, 2024
Merged

shortened paste URL does not appear in email #1264

merged 1 commit into from Mar 14, 2024

Conversation

elrido
Copy link
Contributor

@elrido elrido commented Mar 10, 2024

This PR fixes #606

Changes

  • paste URL for email is picked from element with ID pasteurl instead of window, which should contain the shortened URL

rugk
rugk approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather consider this a feature than a bug (but yeah, debatable), but the change itself is of course fine though.

@elrido elrido merged commit 6eb5fdc into master Mar 14, 2024
17 checks passed
@elrido elrido deleted the email-shortend-url branch March 14, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rugk rugk rugk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YOURLS Shortend url does not appear in e-mail
2 participants
@elrido @rugk