Bootstrap 5 template #1287
Bootstrap 5 template #1287
Conversation
current status: - renders without PHP errors & passes unit tests - displays pastes - responsive navbar - right-to-left support - auto dark mode with toggle to be done: - add "Dark Mode" to translation strings - get expiration and format selections to work - fix modals (password, QR-code, etc.) - replace glyphicons with Bootstrap Icons (no longer included) - test all the different settings and combinations - check tab alignment in HTML source
current status: - got expiration and format selections to work - fixed modals (password, QR-code, etc.) - replaced glyphicons with Bootstrap icons (needs CSP relaxation to work) - tested the different settings and combinations - got editor tabs to change active status to be done: - add "Dark Mode" to translation strings - figure out how to change prettify theme when dark mode gets selected - check tab alignment in HTML source
current status: - made prettify theme work with dark mode to be done: - fix password modal display - add "Dark Mode" to translation strings - check tab alignment in HTML source
|
Okay, the plan sounds good, but we should actually really aim for deleting the old bootstrap code, it's unmaintained etc. Also, could you possibly add a screenshot to the PR so one can already get a glance on how it looks like? And not to forget… thanks a lot! I imagine this has been much work! 👍 🚀 |
There was a problem hiding this comment.
From a design/QA perspective, did you check whether this works with the existing syntax highlighting stuff? (This likely is not being replaced, though we maybe should look into having some more dynamic one, because now #1196 is unevitable, if the browser decides the theme? This is kind of a UX/UI issue…)
Apart from that I am through, most important things are probably (potential) a10n issues, otherwise just code style stuff…
Co-authored-by: rugk <rugk+git@posteo.de>
|
Ok, so I've got some homework to do next weekend.
We can do, but lets aim for at least some transition period, where the old is available in parallel, should there still new issues crop up when it gets more widely used. So i.e. < 2.0 keep it as a non-default option, 2.0 ~ 2.2 or 2.3 make bootstrap 5 default, keep bootstrap, > 2.2 or 2.3 remove bootstrap. We could consider removing the page template and the now broken zerobin legacy support (option in configuration file, legacy compression JS, etc.) with the 2.0 release. Though that goes offtopic.
Sure, you can find some at: #728 (comment)
Yes, and that was actually some of the more tricky stuff. All the syntax highlighting related JS is in the dark mode JS, since I have to load a different CSS (= remove any existing theme, inject a new theme) every time the switch gets flipped. For the existing templates these themes get loaded with the page and never change. Only the content in the relevant (hidden) preview gets updated from the textarea or loaded paste and an update of prettify gets triggered on it. Fortunately for this case, changing the CSS theme instantly changes the look of the already rendered preview. |
empty only works with variables, not constants - here we want to error out if PATH either isn't defined or does not end in a directory separator, so we can concatenate onto it
Co-authored-by: rugk <rugk+git@posteo.de>
|
Tried to answer/resolve all answers as best I could. Anything else, or Ok as is, can it get merged? |
There was a problem hiding this comment.
Replied there to some comments…
Apart from that already looks kinda good.
We should:
- definitively rip out old template then, especially the page one, as you say… This also reduces the maintenance burden. There is no need to maintain a template nobody uses anymore anyway.
- and yeah I agree that transition period makes totally sense
- note some followup tasks to improve the code etc.
Co-authored-by: rugk <rugk+git@posteo.de>
Co-authored-by: rugk <rugk+git@posteo.de>
This PR fixes #728 and adds an new template called "bootstrap5" based on Bootstrap CSS 5.3.3.
Changes
template = "bootstrap5"to switch to it (Upgrade Bootstrap to v4 or higher #728)langcookie with strictSameSitepropertyNote that in the process of implementing this, some changes to privatebin.js and it's template specific code became necessary. While I have re-tested key functionality with "bootstrap", "bootstrap5" and "page" templates, there is some risk in there that this may have introduced some new issues due to the complexity. An example was with the modals, which in bootstrap 3 & 5 work similarly and have the same API, but don't behave 100% the same.
I would like to not yet switch to this new template by default and rather soonish get this into a point release, so people can test it and provide us feedback, also regarding some of the layout choices. Personally, I'm not too fond of the new default colours and the "flat" look, but wanted to keep it at the defaults or same classes as we do on the current bootstrap 3 template as a starting point.
My suggested rough timeline on this: