chore: ugrade DOMPurify from v3.0.8 to 3.1.2 #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This incluces v3.1.1, which says: > Note that this is a security release and should be upgraded to immediately. https://github.com/cure53/DOMPurify/releases/tag/3.1.1 The release notes of the actual version itself are https://github.com/cure53/DOMPurify/releases/tag/3.1.2 I do not found more information on the vulnerability that apparently is in there. * [x] manually tested and works
elrido
requested changes
May 4, 2024
There was a problem hiding this comment.
Thank you for updating this! It was on my radar, but I usually wait to update all of them at once when release time gets close.
Could you please also update the version in here, for the Mocha unit tests to pass:
Line 20 in 1d755d8
And document your work into CHANGELOG.md:
* CHANGED: Upgrading libraries to: DOMpurify 3.1.2
|
FYI, because none of our JS-files are managed via npm (we only use it for the unit test libraries), Dependabot won't ever update those. |
elrido
approved these changes
May 4, 2024
|
Okay thanks, that did not work/it loaded successfully in my GitHub Codespace for some reason… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes v3.1.1, which says:
https://github.com/cure53/DOMPurify/releases/tag/3.1.1
The release notes of the actual version itself are https://github.com/cure53/DOMPurify/releases/tag/3.1.2
I do not found more information on the vulnerability that apparently is in there.
Also sad that DOMPurify apparently is not updated by Dependabot.