remove version number from doc blocs #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @Version in file header level isn't used on code docs, it is intended for API versions at class or method level - avoids needing to update all these files on version increment - avoids needing to regenerate SRI hashes for privatebin.js through extra phpunit run - simplifies VERSION_FILES list - avoids having to filter above list during loop - adds a few missing doc bloc headers
rugk
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a discussion item in #1334.
@versionat file header level isn't used in code docs, it is intended for API versions at class or method level. See phpdoc documentation, as well as our current PHP & JS docs not displaying/using the version property at all.Changes