Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve icon display #56

Merged
merged 6 commits into from Aug 2, 2016
Merged

Improve icon display #56

merged 6 commits into from Aug 2, 2016

Conversation

rugk
Copy link
Member

@rugk rugk commented Jul 31, 2016

The current icon is way too small and the padding was still the one used when we had the text title there...

New version:
privatebinicon

@@ -4786,7 +4786,8 @@ tbody.collapse.in {

.navbar-brand {
float: left;
padding: 15px 15px;
padding: 3px;
padding-left: 8px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the generated CSS from the Darkstrap project. Please move the custom CSS into css/bootstrap/privatebin.css for all Bootstrap/Darkstrap themes and check what needs to be done in css/privatebin.css for the page theme to integrate the logo there too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already did the latter. Now I also reverted the change here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to move your changes to css/bootstrap/privatebin.css. The bootstrap themes use that one, while css/privatebin.css is used only by the page theme.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, did not knew that.

@rugk
Copy link
Member Author

rugk commented Aug 2, 2016

This should do it now... 😄

@elrido
Copy link
Contributor

elrido commented Aug 2, 2016

Thanks!

@elrido elrido merged commit aa5c926 into master Aug 2, 2016
@elrido elrido deleted the rugk-icon-style branch August 2, 2016 09:32
rugk added a commit that referenced this pull request Aug 10, 2016
This fixes the display now finally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants