Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clever gitignore for vendor dir #83

Merged
merged 5 commits into from Aug 17, 2016
Merged

Clever gitignore for vendor dir #83

merged 5 commits into from Aug 17, 2016

Conversation

rugk
Copy link
Member

@rugk rugk commented Aug 17, 2016

  • To the extent possible under law, I have waived all copyright and related or neighboring rights to this PR and publish it as public domain.

This PR fixes the discussion in #65 (comment) (it's a try, at least)

Changes

  • Ignore vendor dir only partially, allows all PHP files
  • This results in the Composer license file being ignored, so I added it to the general license
  • Removed some other unnecessary files, which had something to do with composer
  • I explicitly needed to exclude the license files, theoretically we could also explicitly include them, so that we do not need to add them to the general license file.
  • Additionally I also excluded test directories. This list can be expanded further.

@rugk rugk mentioned this pull request Aug 17, 2016
1 task
@rugk
Copy link
Member Author

rugk commented Aug 17, 2016

Example of files, which would be included:

    vendor/EXAMPLE.php
    vendor/paragonie/EXAMPLE.php
    vendor/paragonie/random_compat/lib/EXAMPLE.php
    vendor/yzalis/EXAMPLE.php
    vendor/yzalis/identicon/EXAMPLE.php
    vendor/yzalis/identicon/src/EXAMPLE.php

@rugk
Copy link
Member Author

rugk commented Aug 17, 2016

TravisCI failure is only a broken test in TrafficLimiterTest. These tests seem to be quite unstable...
At least there is nothing wrong with this PR.

@elrido
Copy link
Contributor

elrido commented Aug 17, 2016

Thank you for the cleanup!

One thing: The doc/ folder in my dev environment contains all the generated API docs from phpdoc, similarly to the tst/log/ after running phpunit. Could you revert just that one ignore rule?

@rugk
Copy link
Member Author

rugk commented Aug 17, 2016

Mhh, but our own doc should be included, so I'll try to generate the doc to see how to exclude it in a nice way. Maybe only include Markdown files?

@rugk
Copy link
Member Author

rugk commented Aug 17, 2016

Or well, we could of course also just change this command suggested there: phpdoc -d lib/ -t doc/

@elrido
Copy link
Contributor

elrido commented Aug 17, 2016

Thanks!

@elrido elrido merged commit cd02c6e into master Aug 17, 2016
@rugk rugk deleted the novendorignore branch August 17, 2016 19:02
@rugk rugk restored the novendorignore branch December 15, 2016 17:55
@rugk rugk deleted the novendorignore branch December 15, 2016 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants