Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for automatic PHP8 branch updates #843

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Add CI for automatic PHP8 branch updates #843

merged 2 commits into from
Oct 7, 2021

Conversation

rugk
Copy link
Member

@rugk rugk commented Oct 6, 2021

Adds a simple CI for pushing the master branches changes to the php8 branch.

Useful/discussed for #707

Unfortunately we can only really test it if it is merged, of course…

Adds a simple CI for pushing the master branches changes to the php8 branch.

Useful/discussed for #707
@rugk rugk mentioned this pull request Oct 6, 2021
@rugk rugk changed the title Add CI for automatic PHP8 updates Add CI for automatic PHP8 branch updates Oct 6, 2021
@elrido elrido merged commit c5fd602 into master Oct 7, 2021
@elrido elrido deleted the php8-ci branch October 7, 2021 19:00
@elrido
Copy link
Contributor

elrido commented Oct 7, 2021

Thank you, let's give this a try.

@rugk
Copy link
Member Author

rugk commented Oct 9, 2021

Okay huh it fails with:

error: pathspec 'php8' did not match any file(s) known to git

…which is a little strange given this is the correct branch name…

@elrido
Copy link
Contributor

elrido commented Oct 10, 2021

Hm, I'd bet on the actions/checkout trying to be clever and doing a depth=1 checkout, which would not include any other branches.

Looking at the docs, maybe we could do something like this?

- uses: actions/checkout@v2
  with:
    # directly checkout the php8 branch, remove the next action to switch to this branch
    ref: php8
    # Number of commits to fetch. 0 indicates all history for all branches and tags.
    # Default: 1
    fetch-depth: 0

rugk added a commit that referenced this pull request Oct 11, 2021
As per #843 (comment)

Co-Authored-By: El RIDO <elrido@gmx.net>
@rugk rugk mentioned this pull request Oct 11, 2021
@rugk
Copy link
Member Author

rugk commented Oct 11, 2021

Thanks a lot, applied that in #847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants