Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive, sidebar, scroll to top Button added #65

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Responsive, sidebar, scroll to top Button added #65

wants to merge 16 commits into from

Conversation

rohit010pro
Copy link
Contributor

@rohit010pro rohit010pro commented Oct 10, 2022 •
edited
Loading

@Priyanshu85 I have tried to add scroll to top buttton on home page.

@netlify
Copy link

netlify bot commented Oct 10, 2022 •
edited
Loading

✅ Deploy Preview for webtools-kitretsu ready!

Name Link
🔨 Latest commit 19d9057
🔍 Latest deploy log https://app.netlify.com/sites/webtools-kitretsu/deploys/6345b3118ad6c5000878710a
😎 Deploy Preview https://deploy-preview-65--webtools-kitretsu.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rohit010pro
Copy link
Contributor Author

Fixed,
Scroll to top Button working perfectly.

@rohit010pro
Copy link
Contributor Author

rohit010pro commented Oct 11, 2022 •
edited
Loading

@Priyanshu85
Check it
Sidebar added and responsive
but, sidebar not visible

@rohit010pro rohit010pro changed the title Scroll to top button added Responsive, sidebar, scroll to top Button added Oct 11, 2022
@Priyanshu85
Copy link
Owner

@rohit010pro Please fix the navbar and quotes section then!!

@Priyanshu85 Priyanshu85 self-requested a review October 11, 2022 14:03
Priyanshu85
Priyanshu85 requested changes Oct 11, 2022
View reviewed changes
Copy link
Owner

@Priyanshu85 Priyanshu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve the navbar and quote section to as it was before!!

@rohit010pro
Copy link
Contributor Author

rohit010pro commented Oct 11, 2022 •
edited
Loading

Please improve the navbar and quote section to as it was before!!

This Navbar and Quote section is responsive. you can check on different viewports.
Please, check.
I am trying to make site more responsive.

@rohit010pro
Copy link
Contributor Author

rohit010pro commented Oct 11, 2022 •
edited
Loading

@Priyanshu85 Check it. I have changed some styling.
and, i will fix menu under viewport 768px. try if you can fix.
others are looking completely good.
reply if there is any issue.

@rohit010pro
Copy link
Contributor Author

Fixed menu under viewport 768px

@Priyanshu85
Copy link
Owner

Okay now it looks Good @rohit010pro ! the thing is I have to resolve conflicts for this...so give me some days to merge your request!!

@rohit010pro
Copy link
Contributor Author

rohit010pro commented Oct 12, 2022 via email

@rohit010pro
Copy link
Contributor Author

rohit010pro commented Oct 15, 2022 •
edited
Loading

Okay now it looks Good @rohit010pro ! the thing is I have to resolve conflicts for this...so give me some days to merge your request!!

can i make some more changes in the site ?
or
Is there any isssue that can i fix ?

@rohit010pro
Copy link
Contributor Author

Okay now it looks Good @rohit010pro ! the thing is I have to resolve conflicts for this...so give me some days to merge your request!!

Can you merge this PR ?
Or i have to make some changes?

@rohit010pro rohit010pro reopened this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Priyanshu85 Priyanshu85 Awaiting requested review from Priyanshu85

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohit010pro @Priyanshu85