Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean dev #121

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Clean dev #121

merged 2 commits into from
Mar 22, 2023

Conversation

ProkopHapala
Copy link
Collaborator

  • removed all my non-essential WIP projects (like forcefield relaxation, multipole fitting, density compression, OpengGL visualization and CorrectionLoop) ... they are backed up in branch prokop-dev
  • moved some test files into /test folder (I created new one ... I was thinking you olready created one? Maybe it is in different Branch? There may be conflict?)
  • some test files were created by you
  • my test file for tip-spline are meant to be checked by human eye (not automatically), therefore I created sub folder tests/human_eye ... what you think about ti ?
  • there was sub folder /fitPPM which is from @yakutovicha (as far as I know). So I wait for him to confirm I should delete it (it is backedup in prokop_dev branch) ... or he may decide to do something else with it

@yakutovicha
Copy link
Collaborator

  • there was sub folder /fitPPM which is from @yakutovicha (as far as I know). So I wait for him to confirm I should delete it (it is backedup in prokop_dev branch) ... or he may decide to do something else with it

Just keep it there, I will make a follow-up PR to move those.

@yakutovicha
Copy link
Collaborator

@ProkopHapala, Before we start reviewing, can you update your master branch and merge it into clean_dev? It is a bit behind currently.

@ProkopHapala ProkopHapala merged commit c33d3f0 into main Mar 22, 2023
@ProkopHapala ProkopHapala deleted the clean_dev branch March 22, 2023 12:55
@ProkopHapala ProkopHapala mentioned this pull request Mar 22, 2023
@ProkopHapala
Copy link
Collaborator Author

@ProkopHapala, Before we start reviewing, can you update your master branch and merge it into clean_dev? It is a bit behind currently.

OK, but in the process I somehow accidently merged clean_dev to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify useful tests in dev folder and move them to the tests folder. Delete dev folder from root directory
2 participants